• aardA
    link
    fedilink
    arrow-up
    1
    ·
    1 year ago

    Git has different fields for author and committer - and modifying a commit should leave the author field intact, and just change the committer field. It is possible that github does something weird (I’m usually not doing much in their web UI) - but coming from working with git directly I’d expect you to be present in the author field.

    • JackbyDev@programming.dev
      link
      fedilink
      English
      arrow-up
      2
      ·
      1 year ago

      I didn’t write the content of that commit. Author and committer being different is for things like rebasing commits written by other people.

      • aardA
        link
        fedilink
        arrow-up
        2
        ·
        1 year ago

        You mentioned a pull request, and that it got edited - which in my workflow is pulling the commit and amending it.

        • JackbyDev@programming.dev
          link
          fedilink
          English
          arrow-up
          1
          ·
          1 year ago

          Okay, I probably misspoke about the technicalities. I opened a pull request, then they made a new commit and closed the PR (like it was an issue) and didn’t touch the commit. Hope that makes sense now.